Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates dependency dowhy to v0.7 #568

Merged
merged 4 commits into from
Feb 10, 2022
Merged

updates dependency dowhy to v0.7 #568

merged 4 commits into from
Feb 10, 2022

Conversation

xrowan
Copy link
Contributor

@xrowan xrowan commented Feb 4, 2022 •
edited
Loading

  • Updates dependency requirements to allow for use of dowhy up to (and including) version 0.7, which is the latest version of that package
  • Version 0.7 dowhy package changed the method for calculating a refutation estimate with the (random common cause method compared to version 0.6. The relevant change is that the method now runs simulations to estimate an average effect of the randomly generated cofounder.
  • This change required explitly specifying a reasonable (3-10) number of simulations in several places where EconML calls refute_estimate with the random_common_cause method to avoid using the default number of simulations (100) which leads to long running tests (> 1hr).

@xrowan xrowan marked this pull request as draft February 4, 2022 01:53
xrowan
xrowan commented Feb 9, 2022
View reviewed changes
Copy link
Contributor Author

@xrowan xrowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there is already instructions in the notebooks to increase the number of simulations when calculating the refutation estimate.

@xrowan xrowan marked this pull request as ready for review February 9, 2022 20:52
@xrowan xrowan requested a review from kbattocchi February 9, 2022 20:53
kbattocchi
kbattocchi approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xrowan xrowan merged commit 7dd7683 into main Feb 10, 2022
@xrowan xrowan deleted the bump_dowhy_07 branch February 10, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrowan @kbattocchi