Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving issue #1236 #1324

Closed
wants to merge 1 commit into from
Closed

Solving issue #1236 #1324

wants to merge 1 commit into from

Conversation

tifang1
Copy link

@tifang1 tifang1 commented Dec 10, 2024

e.g. Fixes #0

Checklist:

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

This is my first contribution. I'm making a draft PR. The output becomes the expected output shown in #1236. However, some unit tests will fail as a result of this implementation. I'm trying to implement it based on the changes suggested in #1257, and added some comments to make the code more understandable.

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@tifang1 tifang1 requested a review from gmischler as a code owner December 10, 2024 02:58
@Lucas-C
Copy link
Member

Lucas-C commented Dec 10, 2024

Hi @tifang1

Thank you very much for submitting this fix! 👍 🙂

Could you please add a new unit test checking that this corner cased is properly handled, please?
You can find some documentation on how to add unit tests in fpdf2 there: py-pdf.github.io/fpdf2/Development.html#testing

Also the GitHub Actions pipeline is failing because fpdf/fpdf.py has not been formatted with black.

To solve this you can:

pip install black pre-commit
black fpdf/fpdf.py
pre-commit install

@Lucas-C
Copy link
Member

Lucas-C commented Jan 6, 2025

Hi @tifang1 🙂

Are you planning to finish this PR, following the feedback I gave you last month?

@Lucas-C
Copy link
Member

Lucas-C commented Jan 16, 2025

No answer for more than 6 weeks: I'm cLosing this PR.

Feel free to open a discussion or another PR if you want to contribute again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants