Update ufo-architecture.md #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If running the current .user-flowrc.json config it does not run and asks to set up the URL.
- user-flow directory was changed to user-flows as it may and probably will contain multiple.
- Comment/Question.
There is a typescript error when passing the page to a Ufo, I have been passing the ctx but I won't work in a Ufo that uses another Ufo.
The error in question is:
```ts
Argument of type '{ page: Page; }' is not assignable to parameter of type 'UserFlowContext'.
Type '{ page: Page; }' is missing the following properties from type 'UserFlowContext': browser, flow, collectOptions
```
And the code in question is this:
```
export declare class Ufo {
protected page: Page;
constructor({ page }: UserFlowContext);
}
```
We can either grow the class to expose ctx `UserFlowContext` or reduce it by only passing the page.
Or maybe there is a smarter way of doing this, some typescript magic.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running the current .user-flowrc.json config it does not run and asks to set up the URL.
user-flow directory was changed to user-flows as it may and probably will contain multiple.
Comment/Question.
There is a typescript error when passing the page to a Ufo, I have been passing the ctx but I won't work in a Ufo that uses another Ufo.
The error in question is:
And the code in question is this:
We can either grow the class to expose ctx
UserFlowContextor reduce it by only passing the page.Or maybe there is a smarter way of doing this, some typescript magic.