validator registration request bug: reusing public keys #10883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
james-prysm
added
Bug
terencechain
approved these changes
Jun 15, 2022
yeah fee recipient isn't part of the for loop( part of the problem of reusing items in a slice to compose something within the same loop) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
related to #10593
What does this PR do? Why is it needed?
Validator Registration Requests were not being created correctly due to reusing references for slices when constructing an array in the same "for" loop. the reference resulted in resuing the same public key ( the last one in the for loop) multiple times on the validator request.
read more about how references in forloops range statement are used https://go.dev/ref/spec#For_statements
The unit test is improved to make sure the public keys are unique in the request.