Skip to content

Fix 2.8.1 build errors on Linux #13609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Link boost_headeronly in slic3r and libslic3r
This solves the linker error about missing `boost::log` symbols.

Fixes #13608.
jmickelin committed Nov 21, 2024
commit f7a25cae1820444f4e999b429598ca477a35ccb8
3 changes: 2 additions & 1 deletion src/libslic3r/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -524,7 +524,7 @@ cmake_policy(SET CMP0011 NEW)
find_package(CGAL REQUIRED)
cmake_policy(POP)

add_library(libslic3r_cgal STATIC
add_library(libslic3r_cgal STATIC
CutSurface.hpp CutSurface.cpp
Geometry/VoronoiUtilsCgal.hpp Geometry/VoronoiUtilsCgal.cpp
IntersectionPoints.hpp IntersectionPoints.cpp
@@ -596,6 +596,7 @@ target_link_libraries(libslic3r PUBLIC
libigl
agg
ankerl
boost_headeronly
)

if (APPLE)
1 change: 1 addition & 0 deletions src/slic3r/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -450,6 +450,7 @@ target_link_libraries(
fastfloat
OpenSSL::SSL
OpenSSL::Crypto
boost_headeronly
)

if (MSVC)