Provide robust Gunicorn config in multiprocess docs #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| from prometheus_client import multiprocess | ||
| multiprocess.mark_process_dead(worker.pid) | ||
| def child_exit(server, worker): | ||
| import logging |
There was a problem hiding this comment.
It's not safe to do imports inside functions
There was a problem hiding this comment.
So you are suggest that also from prometheus_client import multiprocess has to be moved?
I will need to re-test then, if the try catch is still needed after extracting the import.
We need to use the recently added Gunicorn `child_exited` callback in order to correctly clean up after a segfaulted or OOM-killed worker (for details, see benoitc/gunicorn#1394).
StephanErb
force-pushed
the
gunicorn-doc-fixes
branch
from
c5d5fe1 to
1aee39d
Compare
|
I have pushed a squashed commit with the extracted import. I also dropped the try catch. The previous errors I was seeing happened during import, as this is now done up-front I don't see any significant error potential. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the recently added Gunicorn
child_exitedcallback in order tocorrectly clean up after a segfaulted or OOM-killed worker (for details, see
benoitc/gunicorn#1394 and #115).
The try catch is necessary to guard against unexpected race conditions and
errors in the cleanup logic. I have seen this twice, crippling the master
process in a cascading failure scenario.