Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cache-enable-soft-references default to false #10526

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

dimas-b
Copy link
Member

@dimas-b dimas-b commented Mar 10, 2025

Following up on #10217.

Using soft references in the Nessie cache may cause heavy GC overhead in some environments. While it may be used for fine-tuning Nessie caches to improve performance, enabling it by default seems risky for less advanced users and smaller environments.

Following up on projectnessie#10217.

Using soft references in the Nessie cache may cause heavy GC overhead in
some environments. While it may be used for fine-tuning Nessie caches to
improve performance, enabling it by default seems risky for less advanced
users and smaller environments.
@bigluck
Copy link

bigluck commented Mar 13, 2025

x issue message: I had to disable this configuration too, our server went crazy.

Screenshot 2025-03-13 at 18 14 48

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we revert to the pre-soft-ref defaults for the cache-sizing as well?

@dimas-b
Copy link
Member Author

dimas-b commented Mar 13, 2025

Should we revert to the pre-soft-ref defaults for the cache-sizing as well?

I do not mind, but let's merge this one first :)

@dimas-b dimas-b merged commit 19e07d0 into projectnessie:main Mar 13, 2025
16 checks passed
@dimas-b dimas-b deleted the no-soft-refs-default branch March 13, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants