Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PT-BR translation and making the proper adjustments #6033

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

Jarro01X
Copy link
Contributor

@Jarro01X Jarro01X commented Feb 8, 2025

Proposed changes

This PR adds the Portuguese translation of the README file for Nuclei, addressing the feature request #6032 . The translation aims to enhance the accessibility of Nuclei to Portuguese-speaking users by providing clear and concise instructions in their native language

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by CodeRabbit

  • New Features
    • Expanded language options in the documentation by adding support for Portuguese.
    • Introduced a dedicated Portuguese version of the README, offering detailed installation instructions and usage guidance.
  • Documentation
    • Updated existing language selection sections across several documents to include the new Portuguese link, improving accessibility for Portuguese-speaking users.

@auto-assign auto-assign bot requested a review from dogancanbakir February 8, 2025 04:38
Copy link
Contributor

coderabbitai bot commented Feb 8, 2025

Walkthrough

The pull request updates several README files to include Portuguese language options. It adds new links in README.md, README_CN.md, README_ES.md, README_ID.md, README_JP.md, and README_KR.md. Additionally, a new Brazilian Portuguese README (README_PT-BR.md) is introduced with comprehensive documentation details.

Changes

File(s) Change Summary
README.md, README_JP.md Added a Portuguese language link pointing to README_PT-BR.md
README_CN.md, README_ES.md, README_ID.md, README_KR.md Added a Portuguese language link pointing to README_PT-BR.md
README_PT-BR.md Created a new comprehensive Brazilian Portuguese README file with detailed usage documentation

Possibly related issues

Suggested reviewers

  • ehsandeep

Poem

I’m a rabbit hopping through lines of code,
Bringing Portuguese links down the road.
From README tweaks to a fresh new page,
Our docs now speak in a broader stage.
Hop, hop—celebrate this language upgrade!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecf8406 and 5fd6573.

📒 Files selected for processing (2)
  • README.md (1 hunks)
  • README_JP.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • README_JP.md
  • README.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
README_PT-BR.md (3)

9-17: Add descriptive alt text to images.
Several image tags (e.g. at lines 10–17) do not include alt attributes. For better accessibility and markdownlint compliance, please add appropriate alt text (e.g. “Go version badge”, “Nuclei Releases”, etc.).

For example, change:
    
to:
    Go version badge

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

10-10: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


11-11: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


12-12: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


13-13: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


14-14: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


15-15: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


16-16: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


17-17: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


38-40: Simplify phrasing for performance description.
The sentence at line 40 uses “em um grande número de hosts”, which is somewhat wordy. Consider replacing it with “em inúmeros hosts” for brevity and improved style.

A suggested diff:

- ... proporcionando uma varredura rápida em um grande número de hosts.
+ ... proporcionando uma varredura rápida em inúmeros hosts.
🧰 Tools
🪛 LanguageTool

[style] ~40-~40: “um grande número de” é uma expressão prolixa. É preferível dizer “inúmeros”, “inúmeras”, “muitos” ou “muitas”.
Context: ... proporcionando uma varredura rápida em um grande número de hosts. O Nuclei oferece suporte a uma v...

(PT_WORDINESS_REPLACE_UM_GRANDE_NÚMERO_DE)


340-371: Final sections and markdown lint issues.
A few minor markdown style suggestions:
• Verify that all links (especially those introduced in tables or contributor sections) are properly paired with opening and closing brackets. One static analysis hint flagged an unpaired bracket around line ~362; please double-check the formatting in the credits and resources sections.
• Also, the contributor section punctuation (e.g. isolated “:heart:” symbols) may benefit from minor adjustment for readability.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~349-~349: Sinal de pontuação isolado.
Context: ...tors) e mantêm este projeto atualizado. ❤️ Se você tem uma ideia ou algum t...

(UNLIKELY_OPENING_PUNCTUATION)


[grammar] ~351-~351: Esta palavra é hifenizada.
Context: ...eia ou algum tipo de melhoria, sinta-se à vontade para contribuir e participar do projeto...

(PT_COMPOUNDS_PRE_REFORM_À_VONTADE)


[typographical] ~362-~362: Símbolo sem par: “]” aparentemente está ausente
Context: ...ps://github.com/jaeles-project/jaeles), [ChopChop](https://github.com/michelin/Ch...

(UNPAIRED_BRACKETS)

🪛 markdownlint-cli2 (0.17.2)

343-343: Bare URL used
null

(MD034, no-bare-urls)


345-345: Bare URL used
null

(MD034, no-bare-urls)


355-355: Images should have alternate text (alt text)
null

(MD045, no-alt-text)

README.md (1)

15-24: Navigation and badge section review.
The rest of the header—shields, badges, and social links—looks well integrated. Ensure that all images in this section have appropriate alt text (most already do), and that navigation remains consistent across language-switching links.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

17-17: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


19-19: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


21-21: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


23-23: Images should have alternate text (alt text)
null

(MD045, no-alt-text)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82a5d35 and ecf8406.

📒 Files selected for processing (7)
  • README.md (1 hunks)
  • README_CN.md (1 hunks)
  • README_ES.md (1 hunks)
  • README_ID.md (1 hunks)
  • README_JP.md (1 hunks)
  • README_KR.md (1 hunks)
  • README_PT-BR.md (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • README_ES.md
  • README_KR.md
  • README_ID.md
  • README_CN.md
🧰 Additional context used
🪛 LanguageTool
README_PT-BR.md

[style] ~40-~40: “um grande número de” é uma expressão prolixa. É preferível dizer “inúmeros”, “inúmeras”, “muitos” ou “muitas”.
Context: ... proporcionando uma varredura rápida em um grande número de hosts. O Nuclei oferece suporte a uma v...

(PT_WORDINESS_REPLACE_UM_GRANDE_NÚMERO_DE)


[locale-violation] ~90-~90: “Templates” é um estrangeirismo. É preferível dizer “modelos”.
Context: ...leases/tag/v2.5.2). O projeto [Nuclei-Templates](https://github.com/projectdiscovery/...

(PT_BARBARISMS_REPLACE_TEMPLATES)


[locale-violation] ~92-~92: “templates” é um estrangeirismo. É preferível dizer “modelos”.
Context: ...munidade. Você também pode usar a flag update-templates para atualizar os modelos do Nuclei a ...

(PT_BARBARISMS_REPLACE_TEMPLATES)


[uncategorized] ~349-~349: Sinal de pontuação isolado.
Context: ...tors) e mantêm este projeto atualizado. ❤️ Se você tem uma ideia ou algum t...

(UNLIKELY_OPENING_PUNCTUATION)


[grammar] ~351-~351: Esta palavra é hifenizada.
Context: ...eia ou algum tipo de melhoria, sinta-se à vontade para contribuir e participar do projeto...

(PT_COMPOUNDS_PRE_REFORM_À_VONTADE)


[typographical] ~362-~362: Símbolo sem par: “]” aparentemente está ausente
Context: ...ps://github.com/jaeles-project/jaeles), [ChopChop](https://github.com/michelin/Ch...

(UNPAIRED_BRACKETS)

🪛 markdownlint-cli2 (0.17.2)
README_PT-BR.md

10-10: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


11-11: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


12-12: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


13-13: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


14-14: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


15-15: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


16-16: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


17-17: Images should have alternate text (alt text)
null

(MD045, no-alt-text)


88-88: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)


334-334: Bare URL used
null

(MD034, no-bare-urls)


343-343: Bare URL used
null

(MD034, no-bare-urls)


345-345: Bare URL used
null

(MD034, no-bare-urls)


355-355: Images should have alternate text (alt text)
null

(MD045, no-alt-text)

🔇 Additional comments (4)
README_JP.md (1)

32-34: ⚠️ Potential issue

Inconsistent Portuguese link target in Japanese README.
The newly added link at line 34 is labeled “ポルトガル語” (Portuguese) but it points to README_ES.md rather than the Portuguese README (README_PT-BR.md). Please verify if this is intentional or update it to target README_PT-BR.md.

README_PT-BR.md (2)

1-8: Overall structure and header are clear.
The header and introductory section for this new Portuguese README are well structured.


88-98: Heading level and terminology consistency.
The section title “### Modelos do Nuclei” is appropriate; however, please review the incremental consistency of heading levels throughout the document. Also, verify that command-line flags (such as update-templates) remain in English if that is the intended design, while descriptive text uses Portuguese.

🧰 Tools
🪛 LanguageTool

[locale-violation] ~90-~90: “Templates” é um estrangeirismo. É preferível dizer “modelos”.
Context: ...leases/tag/v2.5.2). O projeto [Nuclei-Templates](https://github.com/projectdiscovery/...

(PT_BARBARISMS_REPLACE_TEMPLATES)


[locale-violation] ~92-~92: “templates” é um estrangeirismo. É preferível dizer “modelos”.
Context: ...munidade. Você também pode usar a flag update-templates para atualizar os modelos do Nuclei a ...

(PT_BARBARISMS_REPLACE_TEMPLATES)

🪛 markdownlint-cli2 (0.17.2)

88-88: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)

README.md (1)

5-11: Incorrect Portuguese link target in language options.
In the language navigation block, the newly added “Portuguese” link at line 11 points to README_ES.md. Based on consistency with other language files (e.g. README_CN.md and README_ID.md use README_PT-BR.md for Portuguese), this link should likely target README_PT-BR.md instead.
A suggested change:

-  <a href="https://github.com/projectdiscovery/nuclei/blob/main/README_ES.md">`Portuguese`</a>
+  <a href="https://github.com/projectdiscovery/nuclei/blob/main/README_PT-BR.md">`Portuguese`</a>

@ehsandeep ehsandeep linked an issue Feb 8, 2025 that may be closed by this pull request
@ehsandeep ehsandeep merged commit 1a354cb into projectdiscovery:dev Feb 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Portuguese translation of README
2 participants