test: fix issue with awaiting promises in tests for ember 5.10 #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anehx
force-pushed
the
fix-ember-release-tests
branch
5 times, most recently
from
457a7d1 to
ff9ed72
Compare
anehx
changed the title
This was referenced Jul 30, 2024
anehx
force-pushed
the
fix-ember-release-tests
branch
from
ff9ed72 to
8c073a5
Compare
|
Offline approved by @czosel |
|
🎉 This issue has been resolved in version 13.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
emberjs/ember.js#20726 should fix this. Let's revert this PR as soon as ember v5.10.2 is released |
|
🎉 This issue has been resolved in version 13.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be necessary since Ember.js v5.10.0. Currently there is an open issue regarding this problem. We'll need to wait for a fix by ember itself and revert this afterwards. I'm subscribed to the issue and will revert this as soon as the issue is resolved.