Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in GenUI to build the settings page #424

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Guocork
Copy link
Contributor

@Guocork Guocork commented Mar 7, 2025

introduce Genui into Robrix

@Guocork Guocork marked this pull request as draft March 7, 2025 07:01
@Guocork Guocork marked this pull request as ready for review March 13, 2025 08:59
@Guocork
Copy link
Contributor Author

Guocork commented Mar 13, 2025

Hello, @kevinaboos
In this PR, I've mimicked Element by using basic components from Genui to implement a settings page. This is just an initial version, so I haven't put much effort into beautifying the pages. The settings page currently supports only three screens: account_page, keyboard_page, and notification_page, with routing functionality between them.

In this PR, I modified the makepad-widget dependency from robrix since Genui needs to depend on the same makepad-widget library as robrix. I changed it to point to the corresponding repository to ensure Genui can be used correctly within robrix. In the future, if we introduce Genui into robrix, robrix will need to provide a stable makepad-widget dependency (ensuring Genui can depend on it reliably), making Genui easier to use for both us and other developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant