Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hit handling in the Message widget #324

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fix hit handling in the Message widget #324

merged 3 commits into from
Jan 16, 2025

Conversation

kevinaboos
Copy link
Member

@kevinaboos kevinaboos commented Jan 15, 2025

Ensure that the Message widget's child widgets receive the hits
that they should, which is all hits not related to opening the new
message context menu

See makepad/makepad#636

Remove ClickableView.

@kevinaboos kevinaboos marked this pull request as draft January 15, 2025 02:30
@aaravlu
Copy link
Contributor

aaravlu commented Jan 16, 2025

It seems that the part2 of issue #271 also need Hit event?
If it's this while it has not been fixed, I shall pause #322 temporarily and make a point of finishing #323

Ensure that the Message widget's child widgets receive the hits
that they should, which is all hits not related to opening the new
message context menu
@kevinaboos
Copy link
Member Author

It seems that the part2 of issue #271 also need Hit event? If it's this while it has not been fixed, I shall pause #322 temporarily and make a point of finishing #323

Yes, you're correct, it does require this to be fixed first.

@kevinaboos kevinaboos changed the title Attempt to fix event hit capture, not yet working Fix hit handling in the Message widget Jan 16, 2025
@kevinaboos kevinaboos marked this pull request as ready for review January 16, 2025 06:26
@kevinaboos kevinaboos merged commit 136a4ff into main Jan 16, 2025
3 checks passed
@kevinaboos kevinaboos deleted the fix_hits_capture branch January 16, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants