Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dimmed theme #105

Closed
wants to merge 2 commits into from
Closed

Add Dimmed theme #105

wants to merge 2 commits into from

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jan 20, 2021

This adds a "dimmed" theme. It's a bit brighter than the Dark version.

  • Add initial version of GitHub Dimmed theme.
  • Finalize GitHub Dimmed theme.

Screen Shot 2021-01-21 at 14 12 22

@jsg2021
Copy link

jsg2021 commented Jan 21, 2021

This preview image looks really good. :) can't wait! I generally prefer your themes.

Will the black panel background have a variant/option to be more in line with surrounding colors?

@simurai
Copy link
Contributor Author

simurai commented Jan 22, 2021

Will the black panel background have a variant/option to be more in line with surrounding colors?

Not sure yet. Currently all the VS Code themes are mostly un-opinionated and use whatever is getting defined in primer/primitives.

Screen Shot 2021-01-22 at 12 15 33

  1. color.bg.canvas
  2. color.bg.canvasInset
  3. color.border.primary

So it depends how these colors will defined for the "Dimmed" and all the other upcoming themes.

Another approach could be to not use the "functional variables" as much. Maybe only where it's super clear like the main editor background, but other things like panel/sidebar can be more opinionated and fine-tuned by mixing colors from the scale.. like:

  1. color.bg.canvas
  2. chroma.mix(color.bg.canvas, scale.black, 0.05).hex()
  3. chroma.mix(color.bg.canvas, scale.gray[8], 0.3).hex()

I guess we'll see once the dimmed colors are more finalized if we want it to be different for VS Code themes.

@simurai
Copy link
Contributor Author

simurai commented Jan 23, 2021

With the 3.0.0 release, this theme should be back to how it used to be a couple days ago. We might still add a "Dimmed" version in the future, but for now I'll close this again.

More details here #114 (comment)

@simurai simurai closed this Jan 23, 2021
@simurai simurai deleted the dimmed branch January 23, 2021 08:09
@simurai simurai mentioned this pull request Mar 22, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants