Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes sed command from Dockerfile #948

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

efremovd
Copy link
Contributor

They were needed before because they changed example config.php to make it workable. Now we don't have it and running sed against main php file just removes a lot of code and forces data path for directory

Example of changes before sed:

// clean and check $root_path
$root_path = rtrim($root_path, '\\/');
$root_path = str_replace('\\', '/', $root_path);
if (!@is_dir($root_path)) {
    echo "<h1>".lng('Root path')." \"{$root_path}\" ".lng('not found!')." </h1>";
    exit;
}

becomes after sed:

$root_path = $_SERVER['DOCUMENT_ROOT'].'/data';
$root_path = $_SERVER['DOCUMENT_ROOT'].'/data';
if (!@is_dir($root_path)) {
    echo "<h1>".lng('Root path')." \"{$root_path}\" ".lng('not found!')." </h1>";
    exit;
}

thus forcing data as a path and ignores whatever what set in config.php

They were needed before because they changed example config.php so make it workable.
Now we don't have it and running sed against main file just removes a lot of code
and forces data path for directory
@prasathmani prasathmani merged commit 12baf03 into prasathmani:master Jan 24, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
They were needed before because they changed example config.php so make it workable.
Now we don't have it and running sed against main file just removes a lot of code
and forces data path for directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants