Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip list --format=freeze instead of pip freeze #167

Merged
merged 6 commits into from
Dec 18, 2020
Merged

Conversation

mmarchetti
Copy link
Contributor

Description

In conda environments, pip freeze lists paths in the requirements.txt file which do not exist locally. This is caused by the PEP 610 metadata present for conda-installed packages, and is exposed by a change in pip 20.1b1.

Connected to #166

Testing Notes / Validation Steps

Publish from virtualenvs and conda envs, without an existing requirements.txt file.

Verified

This commit was signed with the committer’s verified signature.
mmarchetti Michael Marchetti

Verified

This commit was signed with the committer’s verified signature.
mmarchetti Michael Marchetti

Verified

This commit was signed with the committer’s verified signature.
mmarchetti Michael Marchetti

Verified

This commit was signed with the committer’s verified signature.
mmarchetti Michael Marchetti

Verified

This commit was signed with the committer’s verified signature.
mmarchetti Michael Marchetti
Copy link
Contributor

@scottmmjackson scottmmjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to note somewhere that versions up to this are broken with pip 20.1?

Verified

This commit was signed with the committer’s verified signature.
mmarchetti Michael Marchetti
@mmarchetti mmarchetti merged commit dee2b80 into master Dec 18, 2020
@mmarchetti mmarchetti deleted the mm-pip-list branch December 18, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants