-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rust sdk #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Thomas for this PR. Some great work ! 👏
I left inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, requesting for changes. 🙈
Co-authored-by: PhilippeMts <[email protected]>
docs/sdk/specifications.md
Outdated
@@ -0,0 +1,41 @@ | |||
--- | |||
sidebar_position: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, some of the aforementioned indications were probably presumptuous.
I think we never really tell even one word about the fact that other SDKs, for other transformation development languages than Rust, could be developed. Shouldn't we add a word about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Thomas. A few last request for changes.
Co-authored-by: PhilippeMts <[email protected]>
Co-authored-by: PhilippeMts <[email protected]>
I left a comment above but this information can partially be found in Rationale (need to englobe as much languages as possible) and also in Future work where we are specifically mentioning some languages :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks for the whole PR.
What It Does 🔎
Adds documentation about the SDK specification and the Rust SDK
Documentation Updates 📘
Added Rust SDK section with 3 sub-sections: Requirements, Usage and Constraints
How To Test ✔️
yarn build
Linked Issues 🎫