Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rust sdk #4

Merged
merged 22 commits into from
Oct 18, 2021
Merged

Feature/rust sdk #4

merged 22 commits into from
Oct 18, 2021

Conversation

tchataigner
Copy link
Contributor

@tchataigner tchataigner commented Aug 25, 2021

What It Does 🔎

Adds documentation about the SDK specification and the Rust SDK

Documentation Updates 📘

Added Rust SDK section with 3 sub-sections: Requirements, Usage and Constraints

How To Test ✔️

yarn build

Linked Issues 🎫

@tchataigner tchataigner changed the base branch from main to develop August 25, 2021 16:04
Copy link
Contributor

@PhilippeMts PhilippeMts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Thomas for this PR. Some great work ! 👏

I left inline comments.

@PhilippeMts PhilippeMts self-requested a review October 13, 2021 15:51
Copy link
Contributor

@PhilippeMts PhilippeMts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, requesting for changes. 🙈

@@ -0,0 +1,41 @@
---
sidebar_position: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, some of the aforementioned indications were probably presumptuous.

I think we never really tell even one word about the fact that other SDKs, for other transformation development languages than Rust, could be developed. Shouldn't we add a word about that?

Copy link
Contributor

@PhilippeMts PhilippeMts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas. A few last request for changes.

@tchataigner
Copy link
Contributor Author

I think we never really tell even one word about the fact that other SDKs, for other transformation development languages than Rust, could be developed. Shouldn't we add a word about that?

I left a comment above but this information can partially be found in Rationale (need to englobe as much languages as possible) and also in Future work where we are specifically mentioning some languages :)

Copy link
Contributor

@PhilippeMts PhilippeMts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for the whole PR.

@tchataigner tchataigner merged commit 4c63ac2 into develop Oct 18, 2021
@tchataigner tchataigner deleted the feature/rust-sdk branch October 18, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants