-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jupiter testnet #4334
add jupiter testnet #4334
Conversation
/* eslint-disable sort-keys */ | ||
|
||
export default { | ||
LookupSource: 'MultiAddress' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also have Address: 'MultiAddress
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jacogr
We define for type Address
is same to node-template
define(pub type Address = sp_runtime::MultiAddress<AccountId, ()>;
). Thus there are two points related to this:
-
node-template
have not changed the define oftypes: { Address: 'AccountId', LookupSource: 'AccountId' }
We think this should be changed after the pr More Extensible Multiaddress Format paritytech/substrate#7380 in substrate,
using:
{ "LookupSource": "MultiAddress", "Address": "LookupSource" }
We may create a pr to fix this if you will, or you may have some your own considerations.
-
In our chain, using
polkadot.js
would use default config, thus, innode
config, the default already has:"Address": "LookupSource"
thus we just override
LookupSource: 'MultiAddress'
is ok. But you are right, override both
LookupSource
andAddress
may be better, we will change later, thanks!
add ```Address: 'MultiAddress'``` types.
Hi, @jacogr . I have added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
hi there,
this PR is to add jupiter testnet.
greetings!