fix(HMS-3731): workaround for cloudwatch type field #162
Conversation
Temporary workaround that fill type with "cloudwatch" string when we fill the cloudwatch configuration. Once the referenced PR is merged, we can remove See: RedHatInsights/clowder#627 Signed-off-by: Alejandro Visiedo <[email protected]>
Add assert to check the value when cloudwatch is used is "cloudwatch". Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-3731-fix-cloudwatch
branch
from
4cb812e to
9190a58
Compare
|
I've talked to the author of the clowder fix (psav). They discovered two years ago, that they always set logging.type to "" instead of "cloudwatch". However a lot of projects already check for "" as the cloudwatch case so they didn't commit to fix it. He said all projects would have to change. However it is a bug and should be fixed, but in the meantime a lot more projects use cloudwatch and the number of projects implementing a workaround increases. So the question is if them will ever fix it or not. If they don't fix it, they should check all the documentations and remove logging.type = "cloudwatch". I think that the current implementation is the best workaround whatever they decide :-) |
|
My apologize, I realized about squash the commits when already pressed the merge button. |
This workaround would fix the cloudwatch situation, so
the type field is filled with
"coudwatch"string whenthe cloudwatch values are merged on the service configuration.
When RedHatInsights/clowder#627 PR
is merged, we can revert the first commit of this PR.