Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(middleware): rename argument names like 'a', 'f' #3032

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Feb 28, 2025

Summary

  • The argument names arg, a, f and fn are used, and they will be clarified and standardized.

Check List

  • pnpm run fix for formatting and linting code and docs

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 8:39am

Copy link

codesandbox-ci bot commented Feb 28, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Feb 28, 2025

Open in Stackblitzdemostarter

npm i https://pkg.pr.new/zustand@3032

commit: fd210de

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind much, but there isn't much hesitation to reject.

@dai-shi dai-shi merged commit a1c7f1c into pmndrs:main Feb 28, 2025
28 checks passed
@sukvvon sukvvon deleted the refactor/middleware-arg-name-clarify branch February 28, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants