Chore/enhance prettier config #2990
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -73,7 +73,6 @@ | |||
| "semi": true, | |||
| "singleQuote": true, | |||
| "tabWidth": 2, | |||
| "tabs": false, | |||
There was a problem hiding this comment.
Prettier reported it's ignored.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/6ZC4J7S4K |
See documentations for usage instructions.
website/package.json
Outdated
| @@ -73,7 +73,6 @@ | |||
| "semi": true, | |||
| "singleQuote": true, | |||
| "tabWidth": 2, | |||
| "tabs": false, | |||
| "trailingComma": "all", | |||
| "tailwindConfig": "./tailwind.config.js" | |||
There was a problem hiding this comment.
This line produces warnings as prettier first of all do not have configured plugins: ["prettier-plugin-tailwindcss"], but even if added, it produces error that prettier-plugin-tailwindcss cannot be found. That's because it's not a monorepo and prettier from root does not sees plugin from website.
Options I see:
- remove this tailwind prettier plugin and corresponding config (seems not working to me anyway)
- add
websiteto root.prettierignore, add newtest:formatcommand topackage.jsonofwebsiteand modify Github workflow to run newtest:formatinsidewebsidefolder.
There was a problem hiding this comment.
Let's remove "prettier" config in website/package.json entirely and remove prettier-plugin-tailwindcss for now.
I'll ask @sandren later if they want it and will add it in the root package.json if necessary.
There was a problem hiding this comment.
Done. Plugin removed as well as prettier config in website/package.json. ✅
.prettierignore
Outdated
| @@ -1,4 +1,3 @@ | |||
| dist | |||
| package.json | |||
There was a problem hiding this comment.
Does it make something too weird if we remove this?
There was a problem hiding this comment.
Removed. I do not see any problems with package.json and prettier for now.
kretajak
force-pushed
the
chore/enhance-prettier-config
branch
from
9f14d36 to
265ff68
Compare
kretajak
force-pushed
the
chore/enhance-prettier-config
branch
from
265ff68 to
27d2c47
Compare
There was a problem hiding this comment.
This looks great!
We make all three repos in sync: zustand, jotai and valtio.
Can you please open two PRs for the same change in https://github.com/pmndrs/zustand and https://github.com/pmndrs/valtio ?
I'll merge three of them all at once.
|
Summary
Prettier configuration is tweaked to pretty more files.
Check List
pnpm run fixfor formatting and linting code and docs