-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add plotly[express] extra for easily installing Plotly Express dependencies #4644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
143acb0
9423aa1
abc41f5
21eef7a
e2bcd8b
33c446c
e7e5377
285f270
f377590
a8ef32e
a42bfb3
1c4c3c9
9818daf
6454bf5
493952a
6074eea
340372a
b49da0e
1607ccf
b8c5faa
c541ce1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -140,17 +140,17 @@ We will support Python 3.12 and higher versions soon. | |
|
||
### Install requirements - (Non-Windows) | ||
```bash | ||
(plotly_dev) $ pip install -r packages/python/plotly/requirements.txt | ||
(plotly_dev) $ pip install -r packages/python/plotly/optional-requirements.txt | ||
(plotly_dev) $ pip install -r packages/python/plotly/requires-install.txt | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this step required in contributing.md? I think it's covered by the editable install of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch @LiamConnors , I'll remove this (I verified that the setup instructions still work without this step, at least on Mac) |
||
(plotly_dev) $ pip install -r packages/python/plotly/requires-dev.txt | ||
``` | ||
### Install requirements - (Windows + Conda) | ||
Because Windows requires Visual Studio libraries to compile some of the optional dependencies, follow these steps to | ||
complete installation and avoid gdal-config errors. | ||
|
||
```bash | ||
(plotly_dev) $ pip install -r packages/python/plotly/requirements.txt | ||
(plotly_dev) $ pip install -r packages/python/plotly/requires-install.txt | ||
(plotly_dev) $ conda install fiona | ||
(plotly_dev) $ pip install -r packages/python/plotly/optional-requirements.txt | ||
(plotly_dev) $ pip install -r packages/python/plotly/requires-dev.txt | ||
``` | ||
|
||
### Editable install of plotly packages | ||
|
@@ -173,7 +173,7 @@ documentation on _development mode_. | |
This repo uses the [Black](https://black.readthedocs.io/en/stable/) code formatter, | ||
and the [pre-commit](https://pre-commit.com/) library to manage a git commit hook to | ||
run Black prior to each commit. Both pre-commit and black are included in the | ||
`packages/python/plotly/optional-requirements.txt` file, so you should have them | ||
`packages/python/plotly/requires-dev.txt` file, so you should have them | ||
ndrezn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
installed already if you've been following along. | ||
|
||
To enable the Black formatting git hook, run the following from within your virtual | ||
|
@@ -261,7 +261,7 @@ We take advantage of two tools to run tests: | |
|
||
### Running Tests with `pytest` | ||
|
||
Since our tests cover *all* the functionality, to prevent tons of errors from showing up and having to parse through a messy output, you'll need to install `optional-requirements.txt` as explained above. | ||
Since our tests cover *all* the functionality, to prevent tons of errors from showing up and having to parse through a messy output, you'll need to install `requires-dev.txt` as explained above. | ||
ndrezn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
After you've done that, go ahead and run the test suite! | ||
|
||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
tenacity>=6.2.0 | ||
packaging |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
pandas; python_version <= '3.8' # Loose requirement for older Python as older numpy is not supported | ||
pandas>=2.2.0; python_version > '3.0' # Minimum pin to ensure compatibility with all versions of numpy | ||
ndrezn marked this conversation as resolved.
Show resolved
Hide resolved
|
Uh oh!
There was an error while loading. Please reload this page.