-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
explain that 'stack' barmode also works for px.bar #1987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: doc-prod
Are you sure you want to change the base?
Conversation
Thanks for this PR! I had initially left out "stack" because it's so easy to misunderstand what it does with respect to negative values... We probably should indeed add it but with a clear warning about how unintuitive the output can be. |
I've tried it out on a small example and added a brief note. If you think more explanation is needed there (or my understanding is wrong), please go ahead. It may be a good idea to put a longer description in Out of curiosity, how would you create a stack plot where positive and negative values are stacked separately on the opposite sides of the x-axis? |
Thanks for updating the PR @Ddedalus ! @nicolaskruchten I think we can merge this one? |
Review change Co-Authored-By: Emmanuelle Gouillart <[email protected]>
Right, so to stack above and below zero the option is “relative”. The “stack” option is supported but needs a clear and scary warning like “this is almost never what you want to use and will often mislead viewers when negative values are involved” or something like that. We have to support it for backwards compatibility reasons but IMO it’s quite a dangerous option. |
1a182ff
to
cbe41e6
Compare
Hi, this is my first pull request, if I choose the wrong branch, please let me know :)
Just a small extension to the available options of
px.bar
to begin with.