Fix dict ordering assumption for Python < 3.6.0 #1464
Merged
+23
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1462, issue is that we were relying on the preservation of dict insertion order during batch updates. This was fine for Python 3.6+, but not for 2.7 and, I suspect, not for 3.5. Now use
OrdererdDict
objects.Some background at https://stackoverflow.com/questions/39980323/are-dictionaries-ordered-in-python-3-6