Skip to content

Use cimg/node instead of circleci/node #7080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 12, 2024
Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Aug 9, 2024

As mentioned here:

cimg/node is designed to supercede the legacy CircleCI Node.js image, circleci/node

This is still Node 16, but using the cimg/node as a step towards:

Related to

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 9, 2024

Hmm, this didn't see to help. The karma-firefox-launcher is also deprecated, in fact all of karma is, so time is maybe better spent upgrading to something else, than trying to fix it, since a bug-fix wouldn't be merged even if we found an upstream issue.

@gvwilson gvwilson added feature something new P2 considered for next cycle infrastructure build process etc. labels Aug 9, 2024
@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

I don't see last CircleCI run.
@birkskyum Would you please push to rerun the tests?

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 12, 2024

I don't have permission to manually trigger a run, and i don't know why my commits didn't trigger. I can try again today ofc.

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

Please add a newline to draftlogs/7080_change.md file.

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

Could you please fix the errors here?
https://app.circleci.com/pipelines/github/plotly/plotly.js?branch=pull%2F7080

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

FYI - Some of our mathjax tests started failing after Firefox v82. So we had to add those specific version tests.
See #5993.
It would be nice to investigate if https://bugzilla.mozilla.org/show_bug.cgi?id=1709251 is fixed and see if we could run all tests on most recent Firefox then possibly adjust the config for those tests.

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 12, 2024

It's not fixed in Firefox - had a test break. It's open here https://bugzilla.mozilla.org/show_bug.cgi?id=1350755

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

Looking good. Let me re-run the image test.

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

@birkskyum Before I merge, are you happy with the updates in this PR or do you want to add additional commits?

@birkskyum
Copy link
Contributor Author

I'm okay with its current state

Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not always easy to bump dependencies.
💃
Thanks very much for the PR.

@archmoj archmoj merged commit c579845 into plotly:master Aug 12, 2024
1 check passed
@archmoj archmoj added this to the v2.35.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new infrastructure build process etc. P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants