In staticPlot, do not draw-zero length bars #5294
Merged
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinerg
changed the title
|
@antoinerg are you able to confirm that this resolves plotly/orca#345 ? |
Yes, I can confirm! docker run --net=host quay.io/plotly/orca --plotlyjs=https://94388-45646037-gh.circle-artifacts.com/0/dist/plotly.min.js
curl -H "accept: application/pdf" http://localhost:9091/ -d '{"data": [{"y": ["This", "is", "a", "test", "placeholder"], "x": [12, 9, 15, 12, 0], "type": "bar", "orientation": "h"}], "layout": {"xaxis": {"type": "categorical", "showgrid": false, "zeroline": false}, "yaxis": {"title": "test", "zeroline": false}}} > test.pdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5282
I'm not sure it's possible to know that transitions will not be used in a future API call except for when
staticPlotis true. This PR ensures that whenstaticPlotis true, bars of zero-length are drawn with a SVG pathd=M0,0Zwhich is rendered correctly in Chromium's PDF.Note that there is still an issue for Chromium users "printing to PDF" webpages containing interactive plotly.js figure with bars of zero-length. This one is much more complicated to fix in my opinion.