Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting array tickmode on date & log axes #4851

Merged
merged 3 commits into from
May 21, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 20, 2020

This PR fixes #4848 | Before vs After.

It also allows using typed arrays for tickvals.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels May 20, 2020
@archmoj archmoj added this to the v1.54.2 milestone May 20, 2020
@alexcjohnson
Copy link
Collaborator

Ha OK, so we're just removing the restriction on axType. Makes me wonder why that was there in the first place but that's probably lost to the mists of time... looks great and it does appear to work! One thing I was worried about is if on log axes tickvals would need to be in linearized form (0,1,2), but they're in data form (1,10,100) as they should be 🎉

Let's add a mock showing both axis types - here's your codepen modified to include log, that would be sufficient I think: https://codepen.io/alexcjohnson/pen/ExVrYrP - then it would be ready to go!
Screen Shot 2020-05-20 at 10 53 48 PM

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a beautiful test image 😂
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly setting tickmode to array disables tickvals in date axis
2 participants