Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev install static eval #4799

Merged
merged 3 commits into from
May 1, 2020
Merged

Dev install static eval #4799

merged 3 commits into from
May 1, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 1, 2020

In respect to ##4796
This PR helps reduce the number of warnings for using static-eval with glslify.

Before:
before

After:
after

See commit 4de0940 for more info.

Also to mention:
Commit 5d3e0e8
was created using the commands below:

npm audit --json > audit.json
npm audit | sed -r "s/\x1B\[([0-9]{1,3}(;[0-9]{1,2})?)?[mGK]//g" > audit.txt

@plotly/plotly_js

@archmoj archmoj added this to the v1.54.1 milestone May 1, 2020
@archmoj archmoj requested a review from alexcjohnson May 1, 2020 15:15
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 4b33d8f into master May 1, 2020
@archmoj archmoj deleted the dev-install-static-eval branch May 1, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants