Improve sunbust and treemap click events behavior #4454
Merged
+90
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- plotly_click is now always triggers when clicking on sectors except when a custom `plotly_(sunburst|treemap)click` handler return false - `plotly_(sunburst|treemap)click` now includes info about the "next" level that we transition to (if any)
archmoj
reviewed
Dec 31, 2019
|
@etpinard thanks very much for the PR. |
Closed
17 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4338
plotly_clickis now always triggers when clicking on sectorsexcept when a custom
plotly_(sunburst|treemap)clickhandlerreturns false
plotly_(sunburst|treemap)clicknow includes info about the "next"level that we transition to (if any)
Refer to #4338 (comment) for an overview of what the current behaviour is.
Demo: https://codepen.io/etpinard/pen/abzLZYo
cc @plotly/plotly_js