-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added docs about building Plotly correctly with Angular #4182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks very much for the PR! I've never used plotly.js with angular, so I'll ping @andrefarzat and @TomDemulierChevret who could maybe helps us review your patch. |
I don't have time to test this right now, but it seems pretty alright. The only issue for me is that it should include an example with a partial bundle (and if possible a custom bundle) like the existing documentation. |
What is a "partial bundle" and where is the custom bundle? |
https://github.com/plotly/plotly.js/blob/master/dist/README.md#partial-bundles You don't want to bundle the whole plotly.js lib in your app if you only use a specific subset of charts. The current version of the doc didn't cover custom bundle, but it had an exemple for partial bundle (in the "src/tsconfig.app.json" part). |
I found this PR very helpful when trying to build plotly with Angular.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as Angular users have found this helpful, that's good enough for me! 💃
Co-authored-by: alexcjohnson <[email protected]>
Added correct howto to build plotly + angular. Removed old variants since
ng eject
is not possible anymore and not building with webGl is basically useless..