Scatter3d and scattergl handling rgb colors with extra alpha values

[archmoj]

Fixes #3902 .
Colors passed as rgb with an extra alpha value could cause some traces such as scatter3d & scattegl to enable opacity (as if rgba was applied).
This happens while color-normalize parses alpha for rgb similar to rgba.

Also dependencies of various gl modules including regl-splom, regl-scatter2d, regl-line2d, regl-error2d, gl-text are patched and updated in this PR.

@plotly/plotly_js

TODO:

• Adding more tests

[archmoj]

This is now reviewable excluding two reverted commits.
And here is all those patches end up:
colorjs/color-parse@master...archmoj:rgb-has-no-alpha

[etpinard]

I think patching color-parse (in your colorjs/color-parse@master...archmoj:rgb-has-no-alpha) is the way to go, but that would probably be called a breaking change for color-parse.

You can try making a PR right away, but I suspect you'll have to make that an option in order to get it merged.

[etpinard]

Hmm. Do we really want to bump point-cluster?

[archmoj]

It has already been applied within the master branch of regl-scatter2d: gl-vis/regl-scatter2d@cda45ae. Yet we don't have a new reg-scatter2d release.

[etpinard]

Right, so can we wait until we need to bump regl-scatter2d to bump point-cluster?

[archmoj]

Yes. Exactly.

[etpinard]

... unless you feel comfortable with dy/point-cluster@8419f96

[etpinard]

Ah I see, regl-scatter2d uses color-parse. Yep this package-lock diff makes perfect sense. Sorry for the confusion 👌

[etpinard]

@archmoj will it be possible to get this PR in 1.48.0? Do you need anything else from Dima?

[archmoj]

The only blocker is this PR: colorjs/color-normalize#4.
I suspect the reason behind the failed test could be node 12 & not color-rgba 2.1.1?

[archmoj]

@etpinard finally this thing is now reviewable.

[etpinard]

💃 thanks!

[etpinard]

@archmoj Looks like this PR broke ./tasks/noci_test.sh image. On master, I get:

$ ./tasks/noci_test.sh image
renderer error - Uncaught ReferenceError: Plotly is not defined
          Chrome version 59.0.3071.115
          Electron version 1.8.4

adding --debug to

plotly.js/tasks/noci_test.sh

Lines 31 to 38 in b6edba5

	test_image () {
	$root/../orca/bin/orca.js graph \
	$root/test/image/mocks/mapbox_* \
	--plotly $root/build/plotly.js \
	--mapbox-access-token "pk.eyJ1IjoiZXRwaW5hcmQiLCJhIjoiY2luMHIzdHE0MGFxNXVubTRxczZ2YmUxaCJ9.hwWZful0U2CQxit4ItNsiQ" \
	--output-dir $root/test/image/baselines/ \
	--verbose || EXIT_STATE=$?
	}

we get:

which appears to come from to-px, added in commit mikolalysenko/to-px@bd2ce00 released in [email protected]

---

Other info:

• npm ls to-px gives:

• this problem sounds similar to Use @etpinard/gl-text #2783

Maybe bumping down to-px to 1.0.1 in gl-text would fix the problem @archmoj ?

[etpinard]

... and of course, this will be ⛔ blocking ⛔ the release of v1.49.0

[archmoj]

I am on it.