Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display zero number in pie and sunburst text and hover #3847

Merged
merged 3 commits into from
May 9, 2019
Merged

Display zero number in pie and sunburst text and hover #3847

merged 3 commits into from
May 9, 2019
+190 −74

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 9, 2019 •
edited
Loading

Fixes #3843.
@plotly/plotly_js

Before codepen.
After codepen.

@archmoj archmoj added the bug something broken label May 9, 2019
@archmoj archmoj added this to the v1.48.0 milestone May 9, 2019
@etpinard
Copy link
Contributor

etpinard commented May 9, 2019

Very nicely done 💃

@archmoj archmoj merged commit e26f8f4 into master May 9, 2019
@archmoj archmoj deleted the fix3843-display-falsy-zero-number branch May 9, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging this pull request may close these issues.

Zero numbers are neither plotted nor included in hover on sunburst and pie text
2 participants
@archmoj @etpinard