Skip to content

One-sided violins with set width fixes #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2019
Merged

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented May 7, 2019

fixes #3839 (where one baseline had to be updated) and #3840

before: https://codepen.io/etpinard/pen/oRXPBm?editors=0010
after: https://codepen.io/etpinard/pen/mYJGWb?editors=1010

@plotly/plotly_js @nicolaskruchten

@etpinard etpinard added bug something broken status: reviewable labels May 7, 2019
@nicolaskruchten
Copy link
Contributor

The new code pen looks good on my phone!

@nicolaskruchten
Copy link
Contributor

and on my computer :)

@archmoj
Copy link
Contributor

archmoj commented May 8, 2019

Nicely done.
💃

@etpinard etpinard merged commit 8f60e83 into master May 8, 2019
@etpinard etpinard deleted the one-sided-violins-fixes branch May 8, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Violin range/padding for side=positive
3 participants