Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waterfall connector.line.color coerce and default fixup #3788

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Waterfall connector.line.color coerce and default fixup #3788

merged 1 commit into from
Apr 17, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 17, 2019

Fixes #3784 thanks to #3784 (comment).

@plotly/plotly_js
cc: @nicolaskruchten

@archmoj archmoj added bug something broken status: reviewable labels Apr 17, 2019
@etpinard
Copy link
Contributor

Nice. Do you have an idea why we need to update the baselines?

@archmoj
Copy link
Contributor Author

archmoj commented Apr 17, 2019

To avoid updating the baseline we may default to #000 instead of #444.

@etpinard
Copy link
Contributor

Ha. Good to know! I prefer #444, but maybe someone with better eyesight would consider this a breaking change 🤔

@alexcjohnson
Copy link
Collaborator

#000 should be considered a bug, it should match everything else.

@etpinard
Copy link
Contributor

Nicely done @archmoj 💃

@archmoj archmoj merged commit 4f7592e into master Apr 17, 2019
@archmoj archmoj deleted the fix3784-waterfall-connector-line-color branch April 17, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waterfall connector.line.color not in _fullData
3 participants
@archmoj @etpinard @alexcjohnson