sankey: compare links in a flow on hover #3730
Conversation
|
Right now, only the top link within a flow has its hover label exactly above it. All the ones below will be shifted. Should I change this behavior such that the hovered link always has its hover label above it? I think this would be ideal but I'm not sure how easy/hard it would be to implement. 🤔 |
src/traces/sankey/plot.js
Outdated
| // For each related links, create a hoverItem | ||
| for(var i = 0; i < d.flow.links.length; i++) { | ||
| var link = d.flow.links[i]; | ||
| if(gd._fullLayout.hovermode === 'closest' && d.link.pointNumber !== link.pointNumber) continue; |
There was a problem hiding this comment.
So, hovermode: 'x' or 'y' enables the "compare" mode? That's a little unfortunate because sankey don't have x nor y axes, but I guess it's not worth adding a hovermode: 'compare' just for sankey.
give it a shot! If you think it's the ideal behavior, it's definitely worth spending at least one more day on this feature. |
I agree that the current behavior is not good enough. It should be possible to display any hover label via the mouse. For this to work, we need to center it or at least making sure it's not overflowing. Right now it just overflows and thus it becomes invisible: |
|
With commit f00b542 we can reach all hoverlabels and fix #3730 (comment): |
🎉 🍾 🥇 |
antoinerg
added
status: reviewable
feature
|
Brilliant work. 💃 |
|
@antoinerg one sankey
Is it passing on your setup? |
|
@etpinard That one also fails on my machine. |
|
It fails sometimes but it does pass more often than not. I guess this one should be a
|
Closes #3322