Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waterfall trace to finance bundle #3708

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Apr 1, 2019

Quick follow-up of #3531

waterfall is a finance trace and we should make it part of the finance bundle and npm package.

cc @plotly/plotly_js

@etpinard etpinard added this to the v1.47.0 milestone Apr 1, 2019
@archmoj
Copy link
Contributor

archmoj commented Apr 1, 2019

@etpinard Thanks for the fix.
Is it on 1.47 or 1.46?

@etpinard etpinard modified the milestones: v1.47.0, v1.46.0 Apr 1, 2019
@etpinard
Copy link
Contributor Author

etpinard commented Apr 1, 2019

Is it on 1.47 or 1.46?

In 1.46.0 of course. I clicked on the wrong milestone. Thanks for spotting that!

@etpinard etpinard merged commit 95347ea into master Apr 1, 2019
@etpinard etpinard deleted the waterfall-in-finance-bundle branch April 1, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants