Fixup pie/sunburst unhover post plot/calc restyle calls #3662
+186
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- probably a side-effect from a splom-perf PR
archmoj
reviewed
Mar 22, 2019
archmoj
reviewed
Mar 22, 2019
| @@ -16,8 +16,7 @@ exports.name = 'pie'; | |||
| exports.plot = function(gd) { | |||
| var Pie = Registry.getModule('pie'); | |||
| var cdPie = getModuleCalcData(gd.calcdata, Pie)[0]; | |||
|
|
|||
| if(cdPie.length) Pie.plot(gd, cdPie); | |||
| Pie.plot(gd, cdPie); | |||
There was a problem hiding this comment.
@etpinard Could you please elaborate why the condition check is no longer required here?
There was a problem hiding this comment.
Because we need Pie.plot to .exit().remove() the old pie traces.
|
@etpinard Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3618 and another (pretty bad) pie bug, to be merged into the sunburst PR in #3594
Updated jsbin: https://output.jsbin.com/lesidaxoru/1
cc @plotly/plotly_js