Detect and increase pixelRatio in 3D plots when anti-alias is not enabled by hardware #3571
+33
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes for pixelRatio in scatter3d - surface3d - error3d - mesh3d improve padding for ticks in orthographic views in gl-axes3d new gl3d baselines
updated 3 baselines with reduced dims to properly run on CI
…iginal updated 4 baselines with reduces width dimensions to run properly on CI
updated baseline to keep height equal the original baseline
5 tasks
|
Closing in the favour of #3573 which was able to address more bugs while keeping more baselines unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3387 and would also improve the quality of images produced using
saveImage& by CI.More description - coming soon.