Updating dependencies of gl-vis modules #3421
Conversation
|
Is |
package-lock.json
Outdated
| "robust-orientation": "^1.1.3", | ||
| "split-polygon": "^1.0.0", | ||
| "vectorize-text": "^3.2.0" | ||
| }, | ||
| "dependencies": { | ||
| "glslify": { |
There was a problem hiding this comment.
Hmm. That seems off. Looks like glslify didn't get dedupe.
Can you run npm ls glslify and paste its result here?
There was a problem hiding this comment.
There are other packages (i.e. one layer deep) that updated to the latest for each module.
So it could be a preparation before the third attempt on: #3267
Now all at glslify 7.0.0.
Here is what npm ls glslify show:
|
Ok,
nicely done. 💪 Go ahead and bump the gl-vis modules' versions. |
package.json
Outdated
| "regl-line2d": "^3.0.12", | ||
| "regl-scatter2d": "^3.1.2", | ||
| "regl-splom": "^1.0.5", | ||
| "regl-error2d": "git://github.com/gl-vis/regl-error2d#0d27313d932fdb8ffaed17931b7258958bce0b88", |
There was a problem hiding this comment.
I don't have npm publish rights for regl-error2d either 😢
There was a problem hiding this comment.
There was a problem hiding this comment.
@archmoj you should now have npm publish rights.
There was a problem hiding this comment.
I do have. Let me publish the new package. Thanks @etpinard.
| "ndarray": "^1.0.16" | ||
| }, | ||
| "dependencies": { | ||
| "binary-search-bounds": { |
There was a problem hiding this comment.
Could you check npm ls binary-search-bounds? I think I tried using [email protected] in gl3d, but I don't think that worked out. We should double-check.
There was a problem hiding this comment.
Thanks for the note. This test branch related to gl3d (dep2019...dep2019-binary-search) passed on CI.
There was a problem hiding this comment.
And here is the tree.
├─┬ [email protected] (git://github.com/archmoj/3d-view.git#b45ff1ea06664dbbd72c758eb323e7d99b56bcf5) │ └─┬ [email protected] (git://github.com/archmoj/orbit-camera-controller.git#96ea78ca5b7f925b9cba50773915135d3665c5ee) │ └─┬ [email protected] (git://github.com/archmoj/filtered-vector.git#eead60dee81f3d071e9766b45a1343f48a38ccd8) │ └── [email protected] ├─┬ [email protected] │ ├── [email protected] │ └─┬ [email protected] │ └── [email protected] ├─┬ [email protected] │ └── [email protected] ├─┬ [email protected] │ └── [email protected] ├─┬ [email protected] │ └── [email protected] ├─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] deduped │ └─┬ [email protected] │ └── [email protected] deduped ├─┬ [email protected] │ └── [email protected] ├─┬ [email protected] (git://github.com/archmoj/matrix-camera-controller.git#c0f6874c35c2d980297c2b625c2bebd48b89ffff) │ └── [email protected] └─┬ [email protected] └── [email protected]
There was a problem hiding this comment.
@archmoj this here is now the only potentially-blocking item.
What are the differences between binary-search-bounds v1.x and v2.x?
There was a problem hiding this comment.
I think we may leave that for another PR. It seems that I don't have permission to patch and publish those modules...
There was a problem hiding this comment.
mikolalysenko/binary-search-bounds@d047eee#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
This may be relevant to the difference between version 1 and 2.
ndarrays are not supported in Version 2.
|
Ok, some before and after: on
now on this branch:
which is 🎉 , and
which, as you pointed out, only has mikolalysenko/binary-search-bounds@d047eee diff between v1.x and v2.x. So I'd call this an improvement! |
|
@archmoj let's merge this in 💃 Our gl-vis modules have never been this well maintained! |
|
Thanks @etpinard for another encouraging and great review. |
Various gl-vis modules are updated e.g. to use glslify 6.4.1, etc.
@etpinard
CC: @plotly/plotly_js