Finalist - Fix to remove webgl warnings resulted from blank texts in scatter3d #3171
+96
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Oct 26, 2018
package.json
Outdated
| @@ -80,7 +80,7 @@ | |||
| "gl-plot2d": "^1.3.1", | |||
| "gl-plot3d": "^1.5.10", | |||
| "gl-pointcloud2d": "^1.0.1", | |||
| "gl-scatter3d": "^1.0.12", | |||
| "gl-scatter3d": "git://github.com/gl-vis/gl-scatter3d.git#8915d2ec6a89b7dc76e216487e82143dbc165c6f", | |||
There was a problem hiding this comment.
|
Thanks for adding that mock. Go ahead and merge this thing once tests pass 💃 💃 💃 |
etpinard
added a commit
that referenced
this pull request
Oct 29, 2018
etpinard
added a commit
that referenced
this pull request
Oct 29, 2018
Update package-lock for pr #3171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of PR 3133 in which the master changes are fetched and conflicts are resolved i.e. to test & make the process of merging easier.
This PR would resolve issue #704 .
@etpinard
@alexcjohnson