-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dragmode: false #3170
Add dragmode: false #3170
Conversation
Thanks very much for this PR and let me apologize for the delayed response (our 1.42.0 release cycle was a little hectic). Could you confirm that hover still works when |
Sorry, I was away last week. Yes, hover still works in |
Thanks @jonfunkhouser ! I wonder if we could do better. By dragging we effectively halt hover and the hover labels (if any) remain in place. Maybe instead we could treat mouse "drag" as a mouse "move" under Regardless, we'll need to add a test to 🔒 down the hover on |
Yes, I'll add a test for that case. I'll also investigate your suggestion, it makes a lot of sense. |
‘mousemove’ events should emit ‘plotly_hover’ events
Brilliant PR, this will be part of our next minor release. |
This PR adds the
dragmode: false
functionality mentioned in #2844 (comment)I added an example chart with this setting to my existing sample, so this can be previewed on mobile devices: https://jonfunkhouser.github.io/plotly-mobile/