Skip to content

Fix contour labels that required "thousands" suffixes #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

etpinard
Copy link
Contributor

fixes #2755, by setting exponentformat to 'B' in contour label mock axis object- to prevent faulty fallback in Axes.prepTicks and Axis.tickText.

cc @alexcjohnson

- to prevent faulty fallback in Axes.prepTicks and Axis.tickText
@etpinard etpinard added bug something broken status: reviewable labels Jul 11, 2018
@alexcjohnson
Copy link
Collaborator

Nice, I was hoping that one would be easy. Curious though, how did contour_edge_cases not run into this problem?

At some point we should make this exponentformat configurable, but that's a feature rather than a bug.

💃

@etpinard
Copy link
Contributor Author

etpinard commented Jul 11, 2018

Those undefined text pieces reported in #2755 came from this block:

else if(isSIFormat(exponentFormat)) {
v += SIPREFIXES[exponent / 3 + 5];
}

where exponent := 4 (4 for thousands here I think) which isn't covered in contour_edge_cases mock.

@etpinard etpinard merged commit bc56819 into master Jul 11, 2018
@etpinard etpinard deleted the contour-label-exponent-fix branch July 11, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contour plot labels issue - Max Contour/Z data value limited to 9772
2 participants