Scattergl transform fixes #2677
Merged
+303
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by mapping 'selectedpoints' input their post-transform values, using trace._indexToPoints - by clearing 'dirty' flag after 1st of 2 _module.calc call, so that 2nd _module.calc does not append phony batches to scene render queue.
etpinard
commented
May 28, 2018
| } | ||
| } else { | ||
| s = markerSizeFunc(optsIn.line.width); | ||
| s = optsIn.line.width / 2; |
There was a problem hiding this comment.
Before this commit, gl2d_transforms looked like:
etpinard
commented
May 28, 2018
| @@ -219,7 +219,7 @@ function convertMarkerSelection(trace, target) { | |||
| if(target.marker && target.marker.symbol) { | |||
| optsOut = convertMarkerStyle(Lib.extendFlat({}, optsIn, target.marker)); | |||
| } else if(target.marker) { | |||
| if(target.marker.size) optsOut.sizes = target.marker.size; | |||
| if(target.marker.size) optsOut.sizes = target.marker.size / 2; | |||
There was a problem hiding this comment.
Before this commit, gl2d_point-selection looked like:
|
Marking as |
|
Very nice! Great catches on the size and linewidth issues! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All transforms are broken on scattergl traces. Yikes!
Luckily it wasn't too hard to fix them. See c52fbe7 for more details. In the meantime, I also discovered two other bugs that made the
transformsandpoint-selectionmocks look (very) bad) using scattergl traces instead on scatter traces. This PR adds scattergl version of these mocks 🔒 ing down the behavior.cc @alexcjohnson (I'll add a jasmine test tonight or tomorrow morning before 1.38.1)