word breaking in notifier #2210
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well played 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2201
Break and hyphenate (in some browsers) long words. Not needed for English, but potentially important for eg German (long compound words?) and maybe asian languages with no spaces between word characters.
Chrome - regular words:
long words:
FF - regular words:
long words:
taken from https://css-tricks.com/snippets/css/prevent-long-urls-from-breaking-out-of-container/
but modified: using
word-break, no matter what I did there would be cases that short words got broken unnecessarily, so I removed it. Also-moz-hyphensdidn't do anything - which was expected ashyphensis supposed to be supported in FF, but I don't ever seem to see hyphens there regardless.