Ignore bare closing tags in html-like input #1926
Conversation
src/lib/svg_text_utils.js
Outdated
| @@ -400,7 +400,12 @@ function buildSVGText(containerNode, str) { | |||
| } | |||
|
|
|||
| function exitNode(type) { | |||
| // A bare closing tag can't close the root node. If we encounter this it | |||
| // means there's an extra closing tag that can just be ignored: | |||
| if(nodeStack.length === 1) return; | |||
There was a problem hiding this comment.
do you want to log this like we do below for if(type !== innerNode.type)? Though, we don't do anything with this so maybe we should get rid of them both...
There was a problem hiding this comment.
That seems reasonable. Do those log messages show up on-screen? Does that seem desirable?
There was a problem hiding this comment.
just in the console, but I think they also go to sentry when they happen on plot.ly
There was a problem hiding this comment.
or maybe not... not really sure, I haven't looked there. But anyway Lib.log points to console.trace if it exists, otherwise it falls back on console.log
There was a problem hiding this comment.
Added message ✅ "Ignoring unexpected end tag </...>"
|
Nice catch and nice fix! 💃 |
See #1923. This PR modifies svg text utils to ignore dangling closing tags when there's nothing on the stack.