Add plotly-esque point data info to pie & sankey event data #1896
+625
−497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no need for two test suite for pie traces.
... respectively, to make pie trace event data more on-par
with other trace types.
etpinard
commented
Jul 18, 2017
src/traces/sankey/render.js
Outdated
| // for event data | ||
| l.trace = d.trace; | ||
| l.curveNumber = d.trace.index; | ||
| l.pointNumber = 'TODO'; |
etpinard
commented
Jul 18, 2017
| @@ -410,4 +410,101 @@ describe('sankey tests', function() { | |||
| .then(done); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Test hover/click event data:', function() { | |||
There was a problem hiding this comment.
Sankey event data wasn't tested anywhere before
🙃
|
@alexcjohnson might as well include this in |
test/jasmine/tests/pie_test.js
Outdated
| @@ -392,18 +394,22 @@ describe('Test event property of interactions on a pie plot:', function() { | |||
| expect(typeof trace).toEqual(typeof {}, 'points.trace'); | |||
|
|
|||
| var pt = futureData.points[0]; | |||
| expect(Object.keys(pt)).toEqual([ | |||
| expect(Object.keys(pt)).toEqual(jasmine.arrayContaining([ | |||
There was a problem hiding this comment.
nice, didn't know about arrayContaining!
|
No comments from me, very nice! 💃 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1875