Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset selection by doubleclick #1811

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Reset selection by doubleclick #1811

merged 2 commits into from
Jun 26, 2017
+2 −2

Conversation

dy
Copy link
Contributor

@dy dy commented Jun 22, 2017 •
edited by etpinard
Loading

@etpinard
Copy link
Contributor

Does this fix the fancy case too: https://codepen.io/etpinard/pen/weqwVg

@etpinard etpinard added the bug something broken label Jun 22, 2017
@dy
Copy link
Contributor Author

dy commented Jun 23, 2017

@etpinard oh nice catch, thank you!

@etpinard
Copy link
Contributor

Beautifully done. Thanks 👍

@etpinard etpinard merged commit cb9e329 into plotly:master Jun 26, 2017
@etpinard etpinard deleted the dblclick-deselect branch June 26, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deselecting scattergl points via double-clicking doesn't reset their color correctly
2 participants
@dy @etpinard