Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapbox to image context #1598

Merged
merged 2 commits into from
Apr 14, 2017
Merged

Mapbox to image context #1598

merged 2 commits into from
Apr 14, 2017

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Apr 13, 2017

fixes #1598

toImage and downloadImage are broken currently for graphs with mapbox subplot and access token set via the config argument in Plotly.plot (e.g. like on plot.ly embed and shareplot).

- so that toImage works when token is set in config
  argument.
@etpinard etpinard added status: reviewable bug something broken labels Apr 13, 2017
@etpinard etpinard added this to the v1.26.0 milestone Apr 13, 2017
@etpinard
Copy link
Contributor Author

@alexcjohnson might as well get this one in 1.26.0 if you don't mind reviewing this.

@alexcjohnson
Copy link
Collaborator

Yeah, looks legit to me! 💃

@etpinard etpinard merged commit 6255f6d into master Apr 14, 2017
@etpinard etpinard deleted the mapbox-to-image-context branch April 14, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants