add attributes xshift, yshift to annotations #1590
Conversation
| @@ -524,21 +532,17 @@ function drawOne(gd, index) { | |||
|
|
|||
| update[annbase + '.x'] = xa ? | |||
| xa.p2r(xa.r2p(options.x) + dx) : | |||
| ((headX + dx - gs.l) / gs.w); | |||
| (options.x + (dx / gs.w)); | |||
There was a problem hiding this comment.
motivated by the fact that the old way would have needed to explicitly account for shift - notice though in the showarrow: false case I did need to just include shift, due to the auto-anchor business...
| @@ -1127,7 +1132,7 @@ describe('annotation effects', function() { | |||
| } | |||
|
|
|||
| makePlot([ | |||
| {x: 50, y: 50, text: 'hi', width: 50, ax: 0, ay: -40}, | |||
| {x: 50, y: 50, text: 'hi', width: 50, ax: 0, ay: -40, xshift: -50, yshift: 50}, | |||
There was a problem hiding this comment.
Is editable: true tested with xshift / yshift? It's a little hard to tell from the diff.
There was a problem hiding this comment.
yes, all the other tests above this in describe('annotation effects', to which I added xshift: 5, yshift: 5, are editable and failed before I fixed dragging with shifts.
| [0.97, 2.03], [0.97, 2.03], | ||
| ['2000-10-01 08:23:18.0583', '2001-06-05 19:20:23.301'], [-0.245, 4.245], | ||
| [0.9, 2.1], [0.86, 2.14] | ||
| [0.91, 2.09], [0.91, 2.09], |
There was a problem hiding this comment.
so these values changed because the annotations-autorange mock changed?
There was a problem hiding this comment.
so these values changed because the
annotations-autorangemock changed?
correct. I guess that's a hazard of reusing mocks for both images and jasmine tests...
|
All right. Nicely done 💃 |
Adds two new attributes to annotations,
xshiftandyshift.Originally I thought I'd accomplish this by just allowing
standoffto be a 2-vector, but I decided against this for a few reasons:axandaystandoff