Filter transform '!=' operation and 'preservegaps' option #1589
Conversation
etpinard
commented
Apr 12, 2017
etpinard
commented
|
@bpostlethwaite this resolves two feature requests of yours from last December. |
|
nice! Will be interesting to integrate this back into Workspace |
src/transforms/filter.js
Outdated
| @@ -15,7 +15,7 @@ var axisIds = require('../plots/cartesian/axis_ids'); | |||
| var autoType = require('../plots/cartesian/axis_autotype'); | |||
| var setConvert = require('../plots/cartesian/set_convert'); | |||
|
|
|||
| var INEQUALITY_OPS = ['=', '<', '>=', '>', '<=']; | |||
| var INEQUALITY_OPS = ['=', '!=', '<', '>=', '>', '<=']; | |||
There was a problem hiding this comment.
hmm, nonblocking as this isn't new, but seems funny to categorize '=' in INEQUALITY_OPS. How about COMPARISON_OPS?
src/transforms/filter.js
Outdated
| dflt: false, | ||
| description: [ | ||
| 'Determines whether or not gaps in data arrays produced by the filter operation', | ||
| 'are preserved or not.', |
There was a problem hiding this comment.
whether or not... or not
src/transforms/filter.js
Outdated
| 'Determines whether or not gaps in data arrays produced by the filter operation', | ||
| 'are preserved or not.', | ||
| 'Setting this to *true* might be useful when plotting a line chart', | ||
| 'with `connectgaps` set to *true*.' |
There was a problem hiding this comment.
wait, do you mean with connectgaps set to false? connectgaps: true would run connect right over the gaps you just preserved...
There was a problem hiding this comment.
Oh right. Good eye. Thanks!
| @@ -66,23 +67,23 @@ describe('general transforms:', function() { | |||
|
|
|||
| traceOut = Plots.supplyTraceDefaults(traceIn, 0, layout); | |||
|
|
|||
| expect(traceOut.transforms[0]).toEqual({ | |||
| expect(traceOut.transforms[0]).toEqual(jasmine.objectContaining({ | |||
There was a problem hiding this comment.
oh, didn't know about that one, cool!
| expect(out[0].y).toEqual([undefined, undefined, undefined, undefined, 2, 3, 1]); | ||
| expect(out[0].marker.color).toEqual([undefined, undefined, undefined, undefined, 0.2, 0.3, 0.4]); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Are there any interesting cases to test with two filters applied in sequence having different preservegaps values?
There was a problem hiding this comment.
Not yet. I'll add one in a future commit 🚀
- add COMPARISON_OPS list - fixup `preservegaps` description - add `preservegaps` commute tests
| expect(out1[0].x).toEqual([undefined, undefined, undefined, 0, 1]); | ||
| expect(out1[0].y).toEqual([undefined, undefined, undefined, 1, 2]); | ||
| expect(out1[0].marker.color).toEqual([undefined, undefined, undefined, 0.1, 0.2]); | ||
| }); |
There was a problem hiding this comment.
Awesome, thanks for those tests.
|
💃 |
