Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough the wheel event if the scrollbar is at the very top or bottom #1588

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

rpaskowitz
Copy link
Contributor

On a page with several charts, if you happen to have the cursor such that it winds up over a legend with scrollbar as you scroll the page, the scrollbar scrolls, but then captures all further wheel events. This change makes it so that the event is passed through to the page if the scrollbar is at the very top or bottom of the box so that the rest of the page can scroll.

@etpinard etpinard added bug something broken status: reviewable labels Apr 13, 2017
@etpinard etpinard added this to the v1.26.0 milestone Apr 13, 2017
@etpinard
Copy link
Contributor

Makes sense. Thanks very much!

@etpinard etpinard merged commit 1509728 into plotly:master Apr 13, 2017
@rpaskowitz rpaskowitz deleted the passthrough_legend_scroll branch April 14, 2017 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants