Scattermapbox BADNUM (w/o upgrading mapbox-gl) #1564
Merged
+63
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- e.g. in rreusser's plotly-mock-viewer
- so that it handles BADNUM items - does colorscale / size fn item conversions - these were handled in scattermapbox/calc.js previously
- mapbox does this annoying thing were their tiles change on their server independently of the mapbox-gl version used.
- no need for it anymore.
etpinard
commented
Apr 7, 2017
| self.div.removeChild(controlContainer); | ||
|
|
||
| // make sure canvas does not inherit left and top css | ||
| map._canvas.canvas.style.left = '0px'; | ||
| map._canvas.canvas.style.top = '0px'; |
There was a problem hiding this comment.
@rreusser looking good:
alexcjohnson
reviewed
Apr 7, 2017
| if(!Array.isArray(cd) || !cd[0]) { | ||
| cd = [{x: false, y: false, placeholder: true}]; | ||
| cd = [{x: BADNUM, y: BADNUM}]; |
|
can't wait to get rid of nw... 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacement for #1543 to be merged in #1538.
After four days of trying to get newer versions of
mapbox-glto work innw.js, I decided it wasn't worth the trouble. So, in brief, this PR:scattermapbox/convert.js😞